Re: [PATCH v6 0/2] MR2778: mfmediaengine: Add support for video effects.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/main.c:
> +}
> -
>
> static HRESULT WINAPI media_engine_InsertVideoEffect(IMFMediaEngineEx *iface, IUnknown *effect, BOOL is_optional)
>  {
> - FIXME("%p, %p, %d stub.\n", iface, effect, is_optional);
> - struct media_engine *engine = impl_from_IMFMediaEngineEx(iface);
> - HRESULT hr = S_OK;
> - return E_NOTIMPL;
> - TRACE("%p, %p, %d.\n", iface, effect, is_optional);
> -
> - EnterCriticalSection(&engine->cs);
> - hr = media_engine_insert_effect(engine, MEDIA_ENGINE_VIDEO_EFFECT, effect, is_optional);
> - LeaveCriticalSection(&engine->cs);
> -
> - return hr;

Does it crash on Windows with NULL 'effect' ?