Re: [PATCH v2 0/1] MR4674: comctl32/listview: Ignore the lParam to WM_PRINTCLIENT and add tests.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c:
> -
>    ok(clr == RGB(0, 0, 0), "got 0x%lx\n", clr);
> -
>    ret = SendMessageA(hList, WM_PRINTCLIENT, (WPARAM)hdc, params[i]);
> -
>    ok(ret == 0, "got %ld\n", ret);
> -
>    clr = GetPixel(hdc, 1, 1);
> -
>    ok(clr == text_background || (listitem_is_transparent && clr == list_background),
> -
>       "got 0x%lx\n", clr);
> -
>    clr = GetPixel(hdc, 50, 1);
> -
>    ok(clr == RGB(0, 0, 0), "got 0x%lx\n", clr);
> -
>    winetest_pop_context();
> - }
> -
> - /* test parameters when the listview is hidden */
> - ShowWindow(hList, SW_HIDE);
> - for (i = 0; i < ARRAY_SIZE(params); i++)
> - {
> -
>    winetest_push_context("lParam=0x%Ix", params[i]);

These two loops look identical. Could you merge them into a new loop? For example, states = {SW_HIDE, SW_SHOW}; for (i = 0; i < ARRAY_SIZE(states); i++);