Re: [PATCH 0/6] MR50: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h. (v2) (PART 1/2)

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.h:
> struct hlsl_struct_field
>  {
>      struct vkd3d_shader_location loc;
>      struct hlsl_type *type;
>      const char *name;
>      struct hlsl_semantic semantic;
> -
> - /* Bitfield for storing type modifiers specific to this field, subset of
> -
> *   HLSL_TYPE_MODIFIERS_MASK, but can also include interpolation modifiers such as
> -
> *   HLSL_STORAGE_NOINTERPOLATION for pixel shader inputs. */
> unsigned int modifiers;
> - /* Offset of the field within the type it belongs to, in numeric register components. */
> unsigned int reg_offset;
> -
> - /* Offset where the fields's name starts in the output bytecode. */
> size_t name_bytecode_offset;

I'd leave the newline here. Also, output in bytes (right?)