On Tue Dec 5 21:50:41 2023 +0000, Alexandre Julliard wrote:
I also implemented test case for non-NULL hFile but I didn't bother
for other flags since I don't know if we even care about those. We don't care unless there's an app that depends on this. In particular, we don't want to reject potentially invalid flags combination unless there's a clear need.
There can be benefits, application that works on Windows either won't pass such flag combination at all (so doesn't matter what Wine does) or it works in Windows only because Windows does return `ERROR_INVALID_PARAMETER`.
And Wine not returning `ERROR_INVALID_PARAMETER` can cause application to fail much later which could make it more difficult to understand where the real issue is.
Anyway I don't have any example where this would matter but my thinking is it would be better to stick how it works in Windows.
Only `non-NULL hFile` handling makes behavior difference in LoL so I could make separate MR just for that change.