Re: [PATCH 0/8] MR5881: d3dx9: Use shared code for loading volumes/volume textures from files.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c:
> - hr = D3DXCreateVolumeTextureFromFileInMemoryEx(device, bmp_32bpp_4_4_argb, sizeof(bmp_32bpp_4_4_argb),
> -
>        D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, D3DUSAGE_DYNAMIC, D3DFMT_UNKNOWN, D3DPOOL_DEFAULT,
> -
>        D3DX_DEFAULT, D3DX_FILTER_POINT, 0, &img_info, NULL, &texture);
> - todo_wine ok(hr == D3D_OK, "Got unexpected hr %#lx.\n", hr);
> - if (SUCCEEDED(hr))
> - {
> -
>    check_texture_mip_levels(texture, 3, FALSE);
> -
>    check_image_info(&img_info, 4, 4, 1, 1, D3DFMT_A8R8G8B8, D3DRTYPE_TEXTURE, D3DXIFF_BMP, FALSE);
> -
>    check_volume_texture_level_desc(texture, 0, D3DFMT_A8R8G8B8, D3DUSAGE_DYNAMIC, D3DPOOL_DEFAULT, 4, 4, 1, FALSE);
> -
>    check_volume_texture_level_desc(texture, 1, D3DFMT_A8R8G8B8, D3DUSAGE_DYNAMIC, D3DPOOL_DEFAULT, 2, 2, 1, FALSE);
> -
>    check_volume_texture_level_desc(texture, 2, D3DFMT_A8R8G8B8, D3DUSAGE_DYNAMIC, D3DPOOL_DEFAULT, 1, 1, 1, FALSE);
> -
> -
>    /*
> -
>     * Check that the values actually get set. Only checking 4x4 and 2x2, 1x1
> -
>     * will vary based on filter implementation.
> -
>     */

Is this something that should be tested and marked `todo` instead?