On Tue Sep 26 22:08:30 2023 +0000, Alfred Agrell wrote:
Ah, that makes more sense. Okay, I can do that, but this is straying pretty far away from the purpose of this MR. And I don't know how well setting media types on samples works in practice - Microsoft's docs are pretty scary and vague [1]. Hopefully we won't find out. (If we do, that belongs in a separate MR.) [1] "To make a significant change to the media type, the pins might need to reconnect and renegotiate the media type." https://learn.microsoft.com/en-us/windows/win32/api/strmif/nf-strmif-imedias... What counts as significant is, as far as I can determine, not defined anywhere.
You can probably just leave that case unimplemented, with a FIXME. It's probably not supposed to happen and you're only interested in handling the case where a format change is detected but it's not actually changing anything visible in the media type.
I'd also suggest using a `compare_media_types` helper that you can copy from some other module.