On Wed Jun 7 21:57:22 2023 +0000, Zebediah Figura wrote:
I get the fear, but I think functionality is important enough in this case. We *probably* want to skip individual parameter type checks if the parameter count doesn't match, but I don't think we want to skip parameter type checks if earlier parameter type checks failed. Perhaps more saliently, I don't think there's a need to be worried about the assumptions we're making. All we need to do is shove the arguments into IR structures. Only after we've finished parsing, and discarded the shader if it already fails, then we can start making assumptions about what the types of arguments are for well-formed IR.
I'm not convinced, and we've got plenty of `return false` anyway in that function. But, as I said, I can pass on this.