Piotr Caban (@piotr) commented about dlls/msvcrt/tests/string.c:
- ok(ret == 185, "Got %d.\n", ret);
- ret = _tolower_l('a', 0);
- ok(ret == 97, "Got %d.\n", ret);
- if (!setlocale(LC_ALL, ".936"))
- {
win_skip("Skip _tolower_l tests.\n");
return;
- }
- ret = _tolower_l('\xa5', 0);
- ok(ret == -91, "Got %d.\n", ret);
- ret = _tolower_l('\xb9', 0);
- ok(ret == -71, "Got %d.\n", ret);
- ret = _tolower_l('a', 0);
- ok(ret == 97, "Got %d.\n", ret);
I think it's _tolower_l/_toupper_l that needs to be fixed (and C locale handling in strnicmp). Please also add tests with unsigned char cast: ```c ret = _tolower_l((unsigned char)'\xa5', 0); ok(ret == 165, "Got %d.\n", ret); ret = _tolower_l((unsigned char)'\xb9', 0); ok(ret == 185, "Got %d.\n", ret); ```