On Fri May 10 20:13:12 2024 +0000, Paul Gofman wrote:
Regarding LOAD_PEDANTIC, I don't think I ever used that. Any idea what
would be potential performance impact? Does it enable some validation incrementally, or is everything validated at every Load_Glyph() call. I grepped freetype code for the usage of that and as far as I can tell the flag is only used to propagate or ignore errors, with all the same checks performed regardless. I also don't see caches used on a way of Load_Glyph. There is a separate cache subsystem in freetype (https://freetype.org/freetype2/docs/reference/ft2-cache_subsystem.html) which I think is supposed to be used explicitly by an application. So apart from specific cases when we weren't falling back to no hinting (an extra Load_Glyph call) and will be falling back now (presumably avoiding rendering glitches which were present before) I don't see it affecting performance. I think if we care to speed that up we should introduce some glyph caching ourselves, possibly not in freetype driver but rather in a generic win32u part?
Opened freetype issue: https://gitlab.freedesktop.org/freetype/freetype/-/issues/1274