25 Oct
2024
25 Oct
'24
10:59 p.m.
On Fri Oct 25 22:42:38 2024 +0000, Alfred Agrell wrote:
You're right, I mixed up the structs. I meant the global state, not the save context. And yes, it needs to be set somewhere. I don't think doparse is correct, though; I think the correct places are domdoc_save and domdoc_get_xml. Hopefully that list won't grow.
To make sure we'd need to do it for all "normal" saves where we can use `xmlSaveSetIndentString` and then all places that call `xmlNodeDumpOutput` directly and indirectly.
That could be a bunch of places, including `node_get_xml`, in our office case. This could easily lead to a regression if we miss one place. Do we want to go that route?