Re: [PATCH v3 0/3] MR1662: winegstreamer: Map MF_SD_LANGUAGE to ISO 639-1.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/wg_parser.c:
>      if (!stream->tags[WG_PARSER_TAG_LANGUAGE])
>      {
> -
>        gst_tag_list_get_string(tag_list, GST_TAG_LANGUAGE_CODE, &stream->tags[WG_PARSER_TAG_LANGUAGE]);
> -
>        gchar *lang_code = NULL;
> -
> -
>        gst_tag_list_get_string(tag_list, GST_TAG_LANGUAGE_CODE, &lang_code);
> -
>        if (lang_code)
> -
>        {
> -
>            /* FIXME: don't convert to ISO 639-1 if the media is ASF. */
> -
>            const gchar *lang_code_iso_639_1 = gst_tag_get_language_code_iso_639_1(lang_code);
> -
>            if (lang_code_iso_639_1)
> -
>                stream->tags[WG_PARSER_TAG_LANGUAGE] = g_strdup(lang_code_iso_639_1);
> -
>            else
> -
>                stream->tags[WG_PARSER_TAG_LANGUAGE] = NULL;

This makes me nervous, because this is potentially introducing a regression.

On the other hand, I don't think there's a known application that depends on MF_SD_LANGUAGE in the first place, so this is probably fine.