Re: [PATCH v2 0/1] MR5864: oledb32: When creating a Data Source, handle non fatal errors.

[Nikolay Sivov (＠nsivov)]

On Tue Jun 18 10:56:00 2024 +0000, Alistair Leslie-Hughes wrote:
> Yes it is but then it's propagate back to to GetDataSource, which
> shouldn't return this value.
> We don't need the trace and it can be removed.  This was just an easy
> way to workout exactly what was wrong.
> Would you happy with something like
> /* Return S_OK for any success code.  */
> if(SUCCEEDED(hr))
>     hr = S_OK;

Depends on what it should do, but yes, if it's not clearly documented and used return code with special meaning, we might as well mask them all.