On 10/10/22 05:13, eric pouech (@epo) wrote:
Does it mean you'd rather wait for that migration to happen before considering migating to long types, or you'd favor long type migration by reducing at max the trace/printf changes (so that it doesn't change twice when considering the two migrations). If the second case, note that:
- it means changing types so that they are the same in lp64 and llp64 (mainly no longer using dword & long, but int:s), example: moving all flags variable / parameters from DWORD to unsigned
- but some plzces will could still require trace changes (eg NSTATUS or GetLastError where I think it s better to keep the windows type for clarity)
I think it would potentially make sense to get rid of long-typed variables in wined3d, though this gets a bit awkward, since e.g. DWORD is propagated in some places from the public interface, and HRESULT is relatively semantically charged. Mostly at this point I'd just advocate inaction.
- it's not very clear what would be preferred between using unsigned vs. uint32_t vs UINT. Current code uses the three forms but couldn't find out a pattern on when to use which.
UINT should probably be replaced with unsigned int. uint32_t would, I think, be preferred when something does specifically need to be 32 bits (e.g. I would prefer it to DWORD for shader token parsing).