[PATCH 1/1] user32/tests: Avoid out-of-bounds access in DdeCreateDataHandle (ASan).

[Bernhard Übelacker]

From: Bernhard Übelacker

---
 dlls/user32/tests/dde.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/dlls/user32/tests/dde.c b/dlls/user32/tests/dde.c
index d54451f3758..c48d1fdfd87 100644
--- a/dlls/user32/tests/dde.c
+++ b/dlls/user32/tests/dde.c
@@ -1883,7 +1883,7 @@ static void test_DdeCreateDataHandle(void)
     item = DdeCreateStringHandleA(dde_inst2, "item", CP_WINANSI);
     ok(item != NULL, "Expected non-NULL hsz\n");

-    hdata = DdeCreateDataHandle(0xdeadbeef, (LPBYTE)"data", MAX_PATH, 0, item, CF_TEXT, 0);
+    hdata = DdeCreateDataHandle(0xdeadbeef, (LPBYTE)"data", 5, 0, item, CF_TEXT, 0);

/* 0 instance id
      * This block tests an invalid instance Id.  The correct behaviour is that if the instance Id
@@ -1893,7 +1893,7 @@ static void test_DdeCreateDataHandle(void)
      */
     DdeGetLastError(dde_inst);
     DdeGetLastError(dde_inst2);
-    hdata = DdeCreateDataHandle(0, (LPBYTE)"data", MAX_PATH, 0, item, CF_TEXT, 0);
+    hdata = DdeCreateDataHandle(0, (LPBYTE)"data", 5, 0, item, CF_TEXT, 0);
     err = DdeGetLastError(dde_inst);
     ok(hdata == NULL, "Expected NULL, got %p\n", hdata);
     ok(err == DMLERR_INVALIDPARAMETER, "Expected DMLERR_INVALIDPARAMETER, got %d\n", err);
@@ -1940,14 +1940,14 @@ static void test_DdeCreateDataHandle(void)

/* cbOff is non-zero */
     DdeGetLastError(dde_inst);
-    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", MAX_PATH, 2, item, CF_TEXT, 0);
+    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", 5, 2, item, CF_TEXT, 0);
     err = DdeGetLastError(dde_inst);
     ok(hdata != NULL, "Expected non-NULL hdata\n");
     ok(err == DMLERR_NO_ERROR, "Expected DMLERR_NO_ERROR, got %d\n", err);

ptr = DdeAccessData(hdata, &size);
     ok(ptr != NULL, "Expected non-NULL ptr\n");
-    ok(size == 262, "Expected 262, got %ld\n", size);
+    ok(size == 7, "Expected 7, got %ld\n", size);
     todo_wine
     {
         ok(ptr && !*ptr, "Expected 0, got %d\n", lstrlenA((LPSTR)ptr));
@@ -1961,7 +1961,7 @@ static void test_DdeCreateDataHandle(void)

/* NULL item */
     DdeGetLastError(dde_inst);
-    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", MAX_PATH, 0, 0, CF_TEXT, 0);
+    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", 5, 0, 0, CF_TEXT, 0);
     err = DdeGetLastError(dde_inst);
     ok(hdata != NULL, "Expected non-NULL hdata\n");
     ok(err == DMLERR_NO_ERROR, "Expected DMLERR_NO_ERROR, got %d\n", err);
@@ -1969,7 +1969,7 @@ static void test_DdeCreateDataHandle(void)
     ptr = DdeAccessData(hdata, &size);
     ok(ptr != NULL, "Expected non-NULL ptr\n");
     ok(!lstrcmpA((LPSTR)ptr, "data"), "Expected data, got %s\n", ptr);
-    ok(size == 260, "Expected 260, got %ld\n", size);
+    ok(size == 5, "Expected 5, got %ld\n", size);

ret = DdeUnaccessData(hdata);
     ok(ret == TRUE, "Expected TRUE, got %d\n", ret);
@@ -1979,7 +1979,7 @@ static void test_DdeCreateDataHandle(void)

/* NULL item */
     DdeGetLastError(dde_inst);
-    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", MAX_PATH, 0, (HSZ)0xdeadbeef, CF_TEXT, 0);
+    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", 5, 0, (HSZ)0xdeadbeef, CF_TEXT, 0);
     err = DdeGetLastError(dde_inst);
     ok(hdata != NULL, "Expected non-NULL hdata\n");
     ok(err == DMLERR_NO_ERROR, "Expected DMLERR_NO_ERROR, got %d\n", err);
@@ -1987,7 +1987,7 @@ static void test_DdeCreateDataHandle(void)
     ptr = DdeAccessData(hdata, &size);
     ok(ptr != NULL, "Expected non-NULL ptr\n");
     ok(!lstrcmpA((LPSTR)ptr, "data"), "Expected data, got %s\n", ptr);
-    ok(size == 260, "Expected 260, got %ld\n", size);
+    ok(size == 5, "Expected 5, got %ld\n", size);

ret = DdeUnaccessData(hdata);
     ok(ret == TRUE, "Expected TRUE, got %d\n", ret);
@@ -1997,7 +1997,7 @@ static void test_DdeCreateDataHandle(void)

/* invalid clipboard format */
     DdeGetLastError(dde_inst);
-    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", MAX_PATH, 0, item, 0xdeadbeef, 0);
+    hdata = DdeCreateDataHandle(dde_inst, (LPBYTE)"data", 5, 0, item, 0xdeadbeef, 0);
     err = DdeGetLastError(dde_inst);
     ok(hdata != NULL, "Expected non-NULL hdata\n");
     ok(err == DMLERR_NO_ERROR, "Expected DMLERR_NO_ERROR, got %d\n", err);
@@ -2005,7 +2005,7 @@ static void test_DdeCreateDataHandle(void)
     ptr = DdeAccessData(hdata, &size);
     ok(ptr != NULL, "Expected non-NULL ptr\n");
     ok(!lstrcmpA((LPSTR)ptr, "data"), "Expected data, got %s\n", ptr);
-    ok(size == 260, "Expected 260, got %ld\n", size);
+    ok(size == 5, "Expected 5, got %ld\n", size);

ret = DdeUnaccessData(hdata);
     ok(ret == TRUE, "Expected TRUE, got %d\n", ret);