Re: [PATCH v2 0/6] MR9517: d3dx{9,10,11}: Implement a box filter.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c:
>  else
>      skip("Failed to create volume texture\n");
>
> - /* Test D3DXFilterTexture() D3DX_DEFAULT behavior. */
> - hr = IDirect3DDevice9_CreateTexture(device, 16, 16, 2, 0, D3DFMT_A8R8G8B8, D3DPOOL_SCRATCH, &tex, NULL);
> - ok(hr == D3D_OK, "Unexpected hr %#lx.\n", hr);
> - IDirect3DTexture9_GetSurfaceLevel(tex, 0, &surf);
> - SetRect(&rect, 0, 0, 16, 16);
> -
> - hr = D3DXLoadSurfaceFromMemory(surf, NULL, NULL, a8r8g8b8_16_16, D3DFMT_A8R8G8B8, 64, NULL,

Not a big deal but I'd write the pitch out as `16 * 4` or `16 * sizeof(uint32_t)` to make it more obvious. Only mentioning it because I remember somewhat recent test fixes for the kind of mistakes one could make by using "magic" numbers.