Re: [PATCH 0/5] MR3528: winegstreamer: Implement windows api frontend for file media sink.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/media_sink.c:
> static HRESULT WINAPI media_sink_AddStreamSink(IMFFinalizableMediaSink *iface, DWORD stream_sink_id,
>      IMFMediaType *media_type, IMFStreamSink **stream_sink)
>  {
> - FIXME("iface %p, stream_sink_id %#lx, media_type %p, stream_sink %p stub!\n",
> - struct media_sink *media_sink = impl_from_IMFFinalizableMediaSink(iface);
> - struct stream_sink *object;
> - HRESULT hr;
> -
> - TRACE("iface %p, stream_sink_id %#lx, media_type %p, stream_sink %p.\n",
>         iface, stream_sink_id, media_type, stream_sink);
> - return E_NOTIMPL;
> - if (!media_type)
> -
>    return E_POINTER;

I think media_type can be NULL, according to MSDN? In which case it's supposed to be set later using the IMFMediaTypeHandler interface. You should probably keep one on the streams (created with `MFCreateSimpleTypeHandler`) instead of a media type.