Re: [PATCH v7 0/1] MR5904: Improve color mode and paper source detection

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/sane.ds/options.c:
>  return sane_find_option(option_name, TYPE_INT, opt);
>
> }
>
> -TW_UINT16 sane_option_probe_mode(TW_UINT16 *current, TW_UINT32 *choices, int *count)
> +static TW_UINT32 sane_categorize_value(const WCHAR* value, const WCHAR* const* filter[], char* categories, int buf_len)
> +{
> - TW_UINT32 i, j;
> - for(i=0; filter[i]; ++i)
> - {
> -
>    if (!*categories)
> -
>    {
> -
>        for(j=0; filter[i][j]; ++j)
> -
>        {
> -
>            if (wcsstr(filter[i][j], value))

This seems like it might be backwards to me? I think it's checking whether the filter string contains the value.