Re: [PATCH v2 0/3] MR6454: msvcrt: Some FIXME once stuff.

[Alfred Agrell (＠Alcaro)]

Alfred Agrell (@Alcaro) commented about dlls/msvcrt/concurrency.c:
> /* ?_Yield@_Context@details@Concurrency@@SAXXZ */
>  void __cdecl Context_Yield(void)
>  {
> - FIXME("()\n");
> - static unsigned int once;
> -
> - if (!once++)

This function looks threading related, so that's a race condition. Probably harmless in practice, but that kinda stuff makes me nervous. (And it'll print again if it overflows.)

I recommend changing to InterlockedOr.