Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/mspatcha/pa19.c:
> - BYTE *old_file_buffer, ULONG old_file_size,
> - ULONG option_flags,  PATCH_OPTION_DATA *option_data,
> - ULONG new_image_base, ULONG new_image_time,
> - const PATCH_IGNORE_RANGE *ignore_range_array, ULONG ignore_range_count,
> - const PATCH_RETAIN_RANGE *retain_range_array, ULONG retain_range_count)
>
> +{
> - int result = 0;
> - ULONG i;
> - IMAGE_NT_HEADERS32 UNALIGNED *nt_headers;
> -
> - UNREFERENCED_PARAMETER(option_data);
> -
> - TRACE("normalizing image at 0x%p with options 0x%lX, new base 0x%lX, new time %lu",
> -
>    old_file_buffer, option_flags, new_image_base, new_image_time);
> -
> - if (old_file_buffer && old_file_size)

Early return would save you a level of indentation here.