30 Jul
2025
30 Jul
'25
4:23 p.m.
On Wed Jul 30 14:17:12 2025 +0000, Nikolay Sivov wrote:
Having a test and returning empty string for empty buffer won't break it for the user.
Surs, the game passes an empty string, but what about other games yet to be tested?
Previously, the function reliably returned `E_NOTIMPL`, so that apps recognized the failure. Now this patch is returning empty string for *all* inputs.
This might fix one game (that only passes empty input), but breaks everything else that passes non-empty input since the function lies that it did the job with an empty output.
If a patch fixes a game and breaks 100 others, then it's not a good patch.