Re: [PATCH 0/8] MR396: vkd3d-shader/hlsl: Support non-constant offset dereferences, v2, part 1.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.c:
>          }
>          vkd3d_string_buffer_printf(buffer, "]");
>      }
> -
>    else if (deref->offset.node)
> -
>    else if (deref->is_lowered)
>    {
>        vkd3d_string_buffer_printf(buffer, "[");
> -
>        dump_src(buffer, &deref->offset);
> -
>        vkd3d_string_buffer_printf(buffer, "]");
> -
>        if (deref->offset.node)
> -
>        {
> -
>            dump_src(buffer, &deref->offset);
> -
>            vkd3d_string_buffer_printf(buffer, "c + ");
> -
>        }
> -
>        vkd3d_string_buffer_printf(buffer, "%uc]", deref->offset_const);

I wouldn't object to only printing the constant offset part if it is different from zero (unless, of course, the relative part is NULL too).