Re: [PATCH 0/1] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour, and update tests accordingly

[Eugene McArdle (＠eugenemcardle)]

On Tue Nov 26 08:14:34 2024 +0000, eric pouech wrote:
> on top of Aida's comments:
> - don't use // comments
> - [1] show that (as you said) Windows behavior changed, so early
>
> (Win7) windows versions show failures. This should be marked with the
> `broken() `macro in the tests (all tests must pass on all platforms)
> - less importantly, [1] also shows some trailing whitespaces in the MR
>
> [1] https://testbot.winehq.org/JobDetails.pl?Key=149951

Would it be preferable to gate those tests behind a version check (similar to how it's done in [1])? That way the new tests are only run when we expect them to succeed, and it won't affect behaviour under older windows versions.

@adamrehn for visibility

[1] https://gitlab.winehq.org/wine/wine/-/blob/wine-9.22/dlls/advapi32/tests/reg...