Re: [PATCH v3 0/1] MR6123: shdocvw: Add IEParseDisplayNameWithBCW semi-stub.

[Dmitry Timoshkov (＠dmitry)]

On Fri Jul 19 15:25:14 2024 +0000, Fabian Maurer wrote:
> Might be a stupid question, but why +3, isn't this triple null terminated?
> Also I noticed you do a sizeof(WORD) for the child ITEMIDLIST, I assume
> to not waste the "BYTE abID[1];". Later you do something similar for
> ie_pidl_data, but using "FIELD_OFFSET(struct ie_pidl_data, name)". I'd
> find it easier to understand if you used the same concept for
> ITEMIDLIST, like  FIELD_OFFSET(ITEMIDLIST, mkid.abID). I have to admit
> it took me a while to get where the WORD was coming from.

Thanks for the review. Does new version of the patch make this clearer?