Re: [PATCH 0/6] MR4459: d3dx9: Support user data in D3DXLoadMeshHierarchyFromXInMemory().

[Paul Gofman (＠gofman)]

On Wed Nov 22 08:15:30 2023 +0000, Matteo Bruni wrote:
> Soooo, this is awkward...
> This would be more idiomatic as:
> STDMETHOD(LoadTopLevelData)(THIS_ ID3DXFileData *child_data) PURE;
>
> and such. But that's no big deal.
> Except, in all the copies of the DX SDK I have readily around (30, 41
> and 43, for the records) the MS header is incredibly missing the This
> pointer as well :expressionless: 
> We probably still want the correct definitions but this is quite
> unfortunate. I'd at least add a comment clarifying that we're
> intentionally diverging from the broken DX SDK header here.

As an alternative we could use private definition in implementation and test, but not sure if keeping the broken definition in public headers helps anything?