On Mon Mar 25 18:40:50 2024 +0000, Tuomas Räsänen wrote:
I think the `!syspath` case deserves `ERR`: all devices in sysfs tree always have unique paths. If udev abstraction somehow fails to convey it, then something is really broken and basically all bets are off regarding current device state. I think `!action` case is similar; it means that something has happened in the device setup but udev has failed to tell us what. That case was logged as WARN and I didn't want to touch that because it was not necessary in the context of this MR. Anyways, point taken, I'll get rid of "on error goto out" -pattern (which I personally tend to prefer).
I just fixed the commit to not use "on error goto out" -pattern but use ERR for `!syspath` case.
I also added a commit which changes WARN to ERR on in `!action` case.