Re: [PATCH v4 0/2] MR1183: d2d1: Update to ID2D1Device1.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/d2d1/factory.c:
> - return S_OK;
>
> +}
> -
>
> +static HRESULT STDMETHODCALLTYPE d2d_factory_CreateDevice(ID2D1Factory3 *iface,
> -
>    IDXGIDevice *dxgi_device, ID2D1Device **device)
>
> +{
> - ID2D1Device1 *device1 = NULL;
> - HRESULT hr;
> -
> - TRACE("iface %p, dxgi_device %p, device %p.\n", iface, dxgi_device, device);
> -
> - if (FAILED(hr = d2d_factory_create_device(iface, dxgi_device, &device1))) {
> -
>    return hr;
> - }
> -
> - *device = (ID2D1Device *)device1;

This does not have to be that verbose. You only need to "return d2d_factory_create_device()".