On Wed Apr 24 17:48:28 2024 +0000, Elizabeth Figura wrote:
A system that allow developers to label explicitly in the huge list of
MR the one considered ready would be great to save time, this is a ugly patchwork solution to get around only one person merging MR, because the Wine project is so large I don't think anyone can handle it alone anymore. I still don't understand. Any commit that is submitted should be considered ready by the submitter (well, there's the "draft" status, but I still don't understand the point of that). Any commit that's been approved by a reviewer is considered ready by that reviewer. What else is necessary? What do you think is the problem that's preventing commits from being applied?
What I also have been noticing recently is a lot of new developers are
submitting patches without knowing how to name commits properly. There's been some of that, though I don't see what the relevance is?
@zfigura If you have an idea, even tho I think the current code is
fine, just send me how you want to be paid, I'm not insanely rich, but if you think you can rework the delete socket file in a way more fitting to be put into Wine, just go for it. Like I said, I don't see a clear way to make the deletion code better. If I did I would have proposed it, no compensation necessary.
This patch still works on master with all tests passing and the software I use it for still works as expected. I think it would be great for this to be merged, but the deletion code not being up to scratch is an understandable barrier. The first version was even worse.
However, at the time I did spend a while looking at ways to get deletion working, and this was the least problematic solution I could come up with. I unfortunately can't really do much more than that unless a more specific criticism than "it's ugly" (which, again, I agree with) is levied. A nominally cleaner solution would probably introduce a lot of extra code just for this one special case, which seems undesired based on feedback for a previous patch of mine, so I'm hesitant to even attempt that. If anyone has any ideas, though, I'm all ears.