Re: [PATCH v5 0/2] MR7678: winewayland: Use system cursor shapes when possible.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winewayland.drv/waylanddrv_main.c:
> - }
> -
> - if (defkey && query_reg_value(defkey, nameW, info, sizeof(buf)))
> - {
> -
>    size = min(info->DataLength, size - sizeof(WCHAR));
> -
>    memcpy(buffer, info->Data, size);
> -
>    buffer[size / sizeof(WCHAR)] = 0;
> -
>    return 0;
> - }
> -
> - return ERROR_FILE_NOT_FOUND;
>
> +}
> -
>
> +static void wayland_init_options(void)
> +{
> - static const WCHAR waylanddriverW[] = {'\','W','a','y','l','a','n','d',' ','D','r','i','v','e','r',0};

I don't think we want to introduce yet another driver specific key, when the trend is to move more things to win32u. Especially when the same option exists already under "X11 Driver".

The question might be: do we even need an option here? If really yes, and although a bit awkward I would suggest to use "X11 Driver" here too, similarly to how win32u does the same for options that are now usable on a wider choice of backends. The idea is at some point to change the name to something generic but I'm not sure how to do that properly.