Re: [PATCH v36 0/7] MR2786: Add support for AF_UNIX sockets

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about server/sock.c:
>  }
>
> #endif
> - case AF_UNIX:
> - {
> -
>    struct WS_sockaddr_un win = {0};
> -
> -
>    if (wsaddrlen < sizeof(win)) return -1;
> -
>    win.sun_family = WS_AF_UNIX;
> -
>    memcpy( win.sun_path, uaddr->un.sun_path, sizeof(win.sun_path) );
> -
>    memcpy( wsaddr, &win, sizeof(win) );
> -
>    return sizeof(win);
> - }
> -

As with ntdll, this looks wrong. I don't think we want to be calling sockaddr_from_unix() or sockaddr_to_unix() at all for AF_UNIX sockets.