Re: [PATCH 0/6] MR4195: winegstreamer: Introduce some helper functions and implement add_stream.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/unixlib.c:
>  return element;
>
> }
>
> -GstElement *find_element(GstElementFactoryListType type, GstCaps *src_caps, GstCaps *sink_caps)
> +GList *find_element_factories(GstElementFactoryListType type, GstCaps *element_sink_caps, GstCaps *element_src_caps)
>  {
> - GstElement *element = NULL;
> - GList *tmp, *transforms;
> - const gchar *name;
> - GList *tmp, *factories = NULL;
> - if (!(transforms = gst_element_factory_list_get_elements(type, GST_RANK_MARGINAL)))
> - if (!(factories = gst_element_factory_list_get_elements(type, GST_RANK_NONE)))

I don't think we want to do this. NONE factories are NONE for a reason (and if that reason is no longer applicable, it should be fixed on the GStreamer side).

Note that this also changes behaviour in a (nontrivial) way that's not called out by the patch subject. Patches should ideally change either behaviour or organization, and if they do both that should be spelled out explicitly.