Re: [PATCH 0/16] MR4046: windows.media.mediacontrol: Implement some IMusicDisplayProperties and IMusicDisplayProperties2 properties.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.media.mediacontrol/display.c:
> static HRESULT WINAPI music_properties_get_Title( IMusicDisplayProperties *iface, HSTRING *value )
>  {
> - FIXME( "iface %p, value %p stub!\n", iface, value );
> - return E_NOTIMPL;
> - struct music_properties *impl = impl_from_IMusicDisplayProperties( iface );
> - TRACE( "iface %p, value %p\n", iface, value );
> - return WindowsDuplicateString( impl->title, value );
>
> }
>
> static HRESULT WINAPI music_properties_put_Title( IMusicDisplayProperties *iface, HSTRING value )
>  {
> - FIXME( "iface %p, value %s stub!\n", iface, debugstr_hstring(value) );
> - return E_NOTIMPL;
> - struct music_properties *impl = impl_from_IMusicDisplayProperties( iface );
> - TRACE( "iface %p, value %p\n", iface, value );
> - return WindowsDuplicateString( value, &impl->title );

You need to release impl->title first if it was previously set.