On Tue Oct 31 18:36:03 2023 +0000, Zebediah Figura wrote:
This can be static now. Let's use enum wg_video_format instead of wg_video_format; the latter is a typedef of UINT32 and therefore the compiler won't recognize it as an enum. I don't particularly like the naming "get_bytes"; that sounds like it's retrieving the actual data in some sense. How about "wg_format_get_max_size_video_raw()", matching the naming scheme for wg_format_to_caps()?
Yeah, I refactored that one about 38 times while creating this MR, some of which called it from other source files. But yeah, this version doesn't, so let's fix it. (Did anyone try compiling Wine with -Wmissing-declarations? That one throws a warning for nonstatic functions with no preceding prototype, and is perfect for catching things that should be static.)
I have no particular opinion on the name, so sure, we can do that.