From: Stefan Dösinger stefan@codeweavers.com
I spent a week debugging an application only to find out that SendMessageTimeout timed out. I think this situation warrants a WARN rather than a TRACE. --- dlls/win32u/message.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c index 2a824dbdab3..9567e5b125a 100644 --- a/dlls/win32u/message.c +++ b/dlls/win32u/message.c @@ -3585,12 +3585,20 @@ static LRESULT retrieve_reply( const struct send_message_info *info,
free( reply_data );
- TRACE( "hwnd %p msg %x (%s) wp %lx lp %lx got reply %lx (err=%d)\n", - info->hwnd, info->msg, debugstr_msg_name(info->msg, info->hwnd), (long)info->wparam, - info->lparam, *result, status ); - /* MSDN states that last error is 0 on timeout, but at least NT4 returns ERROR_TIMEOUT */ - if (status) RtlSetLastWin32Error( RtlNtStatusToDosError(status) ); + if (status) + { + WARN( "hwnd %p msg %x (%s) wp %lx lp %lx got reply %lx (err=%d)\n", + info->hwnd, info->msg, debugstr_msg_name(info->msg, info->hwnd), (long)info->wparam, + info->lparam, *result, status ); + RtlSetLastWin32Error( RtlNtStatusToDosError(status) ); + } + else + { + TRACE( "hwnd %p msg %x (%s) wp %lx lp %lx got reply %lx (err=%d)\n", + info->hwnd, info->msg, debugstr_msg_name(info->msg, info->hwnd), (long)info->wparam, + info->lparam, *result, status ); + } return !status; }