On Tue Jun 10 18:39:40 2025 +0000, Elizabeth Figura wrote:
Where did this advice come from exactly? I've never heard Alexandre request that people not include generated files, only that it's not necessary, and I've seen plenty of patches accepted with generated changes. As far as I can tell "it's not necessary" got somehow warped into "you shouldn't" and then spread as common knowledge.
Thanks for your insight. I understand, but IMHO it's a good idea not to include generated files since they introduce unnecessary merge conflicts.
For example, adding a new syscall results in about half of `dlls/ntdll/ntsyscalls.h` to be rewritten. MRs that (1) add a syscall, and (2) include generated files will surely conflict each other.