On Tue Jul 15 15:31:38 2025 +0000, Mike Kozelkov wrote:
If `CreateFileW()` call failed, should we skip test case iteration? I think it should be skipped because all sequence Save->Load->GetId will fail.
Unlike the implementation, tests generally don’t need to handle every theoretical failure case. Whether one test fails or several, the result is the same, it indicates something that needs fixing.
The problem with using `skip()` is that it allows issues to go unnoticed. It prints a message and leaves a trace, but CI still treats it as a success. `skip()` is useful when detecting configurations that genuinely prevent a test from running, but if we can’t create a temporary file, that seems more like a broken environment than a valid configuration from the test’s perspective.