Hans Leidekker (@hans) commented about dlls/cryptnet/cryptnet_main.c:
len = swprintf(path, ARRAY_SIZE(path), L"%s\\Microsoft\\CryptnetUrlCache\\Content\\", appdata_path); CoTaskMemFree(appdata_path);
- if (len + serial->cbData * 2 * sizeof(WCHAR) > ARRAY_SIZE(path) - 1)
- if (len + CACHED_CERT_HASH_SIZE * 2 * sizeof(WCHAR) > ARRAY_SIZE(path) - 1) { WARN("Serial length exceeds static buffer; not caching.\n"); return INVALID_HANDLE_VALUE; }
The warning needs an update, otherwise this MR looks good.