Re: [PATCH v6 0/5] MR498: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> - {
> -
>    FIXME("Unhandled implicit type.\n");
> -
>    vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> -
>            "Implicit result type for ALLOCA instructions is not supported.");
> -
>    return;
> - }
> - packed_operands &= ~(ALLOCA_FLAG_IN_ALLOCA | ALLOCA_FLAG_EXPLICIT_TYPE);
> -
> - if (!sm6_type_is_array(type[0]) || !sm6_type_is_numeric(elem_type = type[0]->u.array.elem_type))
> - {
> -
>    WARN("Type is not a numeric array.\n");
> -
>    vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> -
>            "Result type of an ALLOCA instruction is not a numeric array.");
> -
>    return;
> - }
> - if (!sm6_type_is_integer(type[1]))

What is `type[1]` supposed to mean? It doesn't seem to be used anywhere. Maybe you can add a comment?