Re: [PATCH v2 0/1] MR962: wined3d: Use a Wine debug channel for vkd3d debug output.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about dlls/wined3d/wined3d_main.c:
>  if (appkey) RegCloseKey( appkey );
>  if (hkey) RegCloseKey( hkey );
>
> - if (!getenv( "VKD3D_DEBUG" ))
> - {
> -
>    if (TRACE_ON(vkd3d)) putenv( "VKD3D_DEBUG=trace" );
> -
>    else if (WARN_ON(vkd3d)) putenv( "VKD3D_DEBUG=warn" );
> -
>    else if (FIXME_ON(vkd3d)) putenv( "VKD3D_DEBUG=fixme" );
> -
>    else if (ERR_ON(vkd3d)) putenv( "VKD3D_DEBUG=err" );
> -
>    else putenv( "VKD3D_DEBUG=none" );
> - }
> - if (!getenv( "VKD3D_SHADER_DEBUG" ))
> - {
> -
>    if (TRACE_ON(vkd3d)) putenv( "VKD3D_SHADER_DEBUG=trace" );

It wouldn't be bad to use a different channel name for `VKD3D_SHADER_DEBUG`, though. Both `VKD3D_DEBUG` and `VKD3D_SHADER_DEBUG` can be very verbose, so it's not bad to selectively pick the one that you really care about.