On Thu Dec 8 16:07:55 2022 +0000, Nikolay Sivov wrote:
Could you try if this patch fixes the crash as well? Calling stop again while in the middle of stopping looks more fragile to me. Existing logic should already cover calls that you added. [patch.diff](/uploads/e1698d75ddf9ee6ec628fdac021820cd/patch.diff)
No, it crashes with that patch, I think it is very sensitive to preemption.
In general, like I described, Start/Stop commands don't seem to be waiting for presentation end to complete and rather interrupt it in the middle while being able to restart the presentation end the next call to Start.
I haven't included tests for the Pause command because the current code doesn't seem to support restarting the end of presentation properly, and I think it would need more changes to, but it's not so different from the Stop test.