On Tue Nov 5 13:42:21 2024 +0000, Zhiyi Zhang wrote:
Right, but I'm not sure how to organize this into two MRs. Would it be
acceptable for the first MR to only contain the stubs for the `I{Observable}Map`, `IMapView`, `IIterable` and `IIterator` interfaces (i.e, the first 8 commits)? Yes, that would work. It can have two or more MRs, as long as each MR is pretty self-contained and easy to review.
For example, "wintypes: Add IObservableMap<HSTRING, IInspectable *> and IIterable<IKeyValuePair<HSTRING, IInspectable *>> stubs to PropertySet implementation." can be split into "Add IObservableMap<HSTRING, IInspectable *>" and "IIterable<IKeyValuePair<HSTRING, IInspectable *>>". When you are using `and` in the subject, it's an indication that it might be possible to split further.