Re: [PATCH 0/8] MR8705: d3dx10: Exclusively use shared code to implement get_image_info().

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/tests/d3dx10.c:
>  }
>
> }
>
> +#define check_dds_pixel_format_unsupported(flags, fourcc, bpp, rmask, gmask, bmask, amask, expected_hr) \
> -
>    check_dds_pixel_format_unsupported_(__LINE__, flags, fourcc, bpp, rmask, gmask, bmask, amask, expected_hr)
>
> +static void check_dds_pixel_format_unsupported_(unsigned int line, DWORD flags, DWORD fourcc, DWORD bpp,
> -
>    DWORD rmask, DWORD gmask, DWORD bmask, DWORD amask, HRESULT expected_hr)

Maybe it makes sense to move the bulk of `check_dds_pixel_format_unsupported_()` and `check_dds_pixel_format_()` to a separate test function taking both `expected_format` and `expected_hr` arguments and have both functions simply call into that with proper arguments?