Re: [PATCH v2 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
> - enum hlsl_regset regset;
> - unsigned int id, bind_count;
> -
> - bool user_packed;
>
> +};
> -
>
> static int sm4_compare_extern_resources(const void *a, const void *b)
>  {
> - const struct hlsl_ir_var *aa = *(const struct hlsl_ir_var **)a;
> - const struct hlsl_ir_var *bb = *(const struct hlsl_ir_var **)b;
> - enum hlsl_regset aa_regset, bb_regset;
> - const struct extern_resource *aa = (const struct extern_resource *)a;
> - const struct extern_resource *bb = (const struct extern_resource *)b;
> -
> - if (aa->regset != bb->regset)
> -
>    return aa->regset - bb->regset;

Given that you're touching this, you could also start using `vkd3d_u32_compare()` and the style used, for example, by `compare_param_hlsl_types()`.