On Tue Aug 23 12:48:03 2022 +0000, Alexandre Julliard wrote:
If you want to test generated files, the right way is for someone to install the PSDK on Windows, generate files with midl, and use that as test sources, similar to the existing generated.c files. Adding a new midl.exe just for the purpose of running tests doesn't make much sense, especially since the Windows VMs don't have the PSDK so the tests will never run there.
It was indeed my intention to depend on the PSDK being installed. Wouldn't it be possible?
I don't understand the reasoning here, unless there's some legal matters.
Having the files generated manually is a workaround, but it's cumbersome and I think it'd better if we could run the tools while the tests are run, eventually saving and committing the results if needed. It also makes sure we keep the commands to generate them committed and tested, avoiding bit rot and being unable to regenerate them later.
This is basically the same as we do elsewhere, for mscoree tests for instance, where we run csc, or for multimedia tests where some are using native tools to generate sample media files to workaround issues with open-source encoders (it's not always done but imho it's superior to using external tools and manual steps to regenerate the files).