Re: [PATCH v7 0/3] MR5924: mfmediaengine: Implement SVR.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/video_frame_sink.c:
> -
>    free(sink);
> - }
> -
> - return refcount;
>
> +}
> -
>
> +static HRESULT WINAPI video_frame_sink_GetCharacteristics(IMFMediaSink *iface, DWORD *flags)
> +{
> - struct video_frame_sink *sink = impl_from_IMFMediaSink(iface);
> -
> - TRACE("%p, %p.\n", iface, flags);
> -
> - if (sink->is_shut_down)
> -
>    return MF_E_SHUTDOWN;
> -
> - *flags = MEDIASINK_FIXED_STREAMS | MEDIASINK_RATELESS | MEDIASINK_CAN_PREROLL;

CAN_PREROLL here is a no-op, because you don't implement preroll interface. So either remove it, or add the interface.