On Wed Aug 7 23:18:53 2024 +0000, Brendan McGrath wrote:
.compare = compare_rgb32, .compare_rect = {.top = 20, .right = 82, .bottom = 104},This is my bad, but I was surprised to find that Windows letter boxes the image when the output is taller, and I realise now that I never updated the `compare_rect` to reflect that. I think top should now be 20 and bottom 104 (but I haven't had a chance to test that). To be completely honest, I'm not against removing the vertical tests for now, as I never included tests for going to a shorter buffer either. That would leave this MR to focus on stride (and a future MR for vertical tests). But I'm not strongly opinionated either way. And to be a complete PITA, I'll be mostly unavailable the next few days.
Alright, I'll leave the vertical tests aside. Fwiw unless there's an application that relies on it I would suggest to not spend time on implementing all the video processor features. It looks like it can do a lot of things (zooming, cropping, padding, etc) that might not be very useful.