Jacek Caban (@jacek) commented about dlls/mshtml/script.c:
- HRESULT hres;
- switch(prop->type) {
- case GLOBAL_SCRIPTVAR: {
IWineJScript *jscript;if(!prop->script_host->script)return E_UNEXPECTED;if(!IsEqualGUID(&CLSID_JScript, &prop->script_host->guid) ||IActiveScript_QueryInterface(prop->script_host->script, &IID_IWineJScript, (void **)&jscript) != S_OK)return S_OK;hres = IWineJScript_GlobalPropExists(jscript, prop->id);IWineJScript_Release(jscript);return hres;
The justification for a new function does not look convincing to me. We could, for example, store script global disp in `ScriptHost` iff we're hosting JS and just use its `GetDispID` here.