On Fri Mar 31 18:58:28 2023 +0000, Connor McAdams wrote:
These coordinates were based on the fact/assumption that when we create our HWND it's at position `0,0` on the screen. On my Win10 machine:
- rect[0] is (8,31)-(128,92) (Window client area)
- rect[1] is (0,0)-(136,100) (Entire window including non-client area rectangle)
So this should set width to 7, and height to 30, which should be within the bounding box of the non-client area and not the client area. I guess we should probably adjust them based on the coordinates of the entire window. Or I guess just a static width/height of 1 might do just as well...
It passes in rect[1] left/top, instead of hard-coding them, so that's an inconsistency where it assumes 0,0 in some places but not others.
Given that the window isn't shown I guess it probably holds for now, but that may be inconvenient if there's a need to show the window later. I think it'd be cleaner to not make the assumption.