On Tue Aug 23 12:26:19 2022 +0000, R��mi Bernon wrote:
It's not because including the C file works in a test or when used to build Wine that it's compatible with the one midl would generate. We compile all the tests with widl, so we only test that these files are usable in our tests, and only to the extend of how the tests and Wine code are using them. We can and probably already have differences that makes midl generated headers incompatible with widl generated ones. We also don't test anything about the C++ generated code, which has been and may still be broken, and I don't think we will add C++ compilation support just for that. I honestly find it quite hard to have to argue for adding more tests in Wine, especially to an area that has current none, and to which contributing has been historically very hard in large part because of the difficulty to foresee the effect of any change. If that's how it is I won't insist, but I'm also probably not going to be very eager to work on widl either.
If you want to test generated files, the right way is for someone to install the PSDK on Windows, generate files with midl, and use that as test sources, similar to the existing generated.c files.
Adding a new midl.exe just for the purpose of running tests doesn't make much sense, especially since the Windows VMs don't have the PSDK so the tests will never run there.