Re: [PATCH 0/3] MR6855: server: Fix renaming file to a hardlink of itself.

[Gabriel Ivăncescu (＠insn)]

On Fri Nov 22 16:18:58 2024 +0000, Jinoh Kang wrote:
> The error check is missing. Copying from above:
>     ret = DeleteFileA(dest);
>     ok(!ret, "DeleteFileA: error %ld\n", GetLastError());
>
> Deletion failures sometimes happen due to e.g., unexpectedly open
> handles w/o FILE_SHARE_DELETE, and leftover files interfere with
> successive tests that assume clean slate.

For some reason this returns non-zero for me on Windows, even though it deletes the file. So I assumed it's flaky in some way? Does it not for you?