On Wed Jan 10 20:51:08 2024 +0000, Francisco Casas wrote:
So indeed, the CI pipeline failed for clip.shader_test and sample-level.shader_test because it runs with extra validations VKD3D_SHADER_CONFIG="force_validation". The sample-level failure happened because we don't support HLSL_RESOURCE_SAMPLE_LOD yet in d3dbc.c and instead of emitting a fixme we are emitting a texld. Patch 3/5 fixes this. The clip.shader_test failure happened because we are incorrectly emitting the SPIR-V for texkill, so Patch 4/5 introduces a VSIR pass to lower texkills to discard_nz`s.
I just realized that I should also remove the `VKD3DSIH_TEXKILL` cases in 4/5 in spirv.c. Well, I will do it after reviews.